Add proto-reservation node as core part of RMF #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
There are a number of objects which obstruct the passage lanes in the office world. This commit removes them. Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
As per a discussion with @mxgrey we are removing references to "chope" Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Arjo Chakravarty <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
Signed-off-by: Michael X. Grey <[email protected]>
mxgrey
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
There was a weird amount of linting that needed to be addressed on old code. I guess noble introduced some changes to the linting tools.
There are some very useful scripts added with this PR, so thanks for that.
We may want to consider just enabling the reservation system for all of the demo worlds, but the office world is a good one to start out with.
arjo129
added a commit
that referenced
this pull request
Dec 16, 2024
I noticed that this launch file was still lying around from #212. I had added it in an early commit of #212 as we initially did not want the reservation system running in the default world. However, now that the reservation system is running in the default office world, this launch file is redundant. Additionally, this launch file references a non-existant launch file in rmf_demos and hence will not work. To reduce confusion I am removing this launch file. Signed-off-by: Arjo Chakravarty <[email protected]>
xiyuoh
pushed a commit
that referenced
this pull request
Dec 16, 2024
I noticed that this launch file was still lying around from #212. I had added it in an early commit of #212 as we initially did not want the reservation system running in the default world. However, now that the reservation system is running in the default office world, this launch file is redundant. Additionally, this launch file references a non-existant launch file in rmf_demos and hence will not work. To reduce confusion I am removing this launch file. Signed-off-by: Arjo Chakravarty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
Adds a proto-reservation system
Depends on:
Implementation description
Just adds a line to start the "chope_node" (choping is the Singaporean act of reserving a table usually using some item)